Setting doNotCacheOnWorkflowFailure: true disables caching entirely (?)

[equeim]

I use run-vcpkg action from my own compisite action like this: https://github.com/equeim/action-setup-vcpkg-msvc/blob/master/action.yml

There I set doNotCacheOnWorkflowFailure input to true. Then, when job is completed successfully, post action from run-vcpkg says that:

Save vcpkg and its artifacts into GitHub service cache
  Caching is disabled, saving cache is skipped.

AFAIK, it can happen only if doNotCache input is true and it false by default.

There is log when run-vcpkg is invoked:

Run lukka/run-vcpkg@v10
  with:
    vcpkgGitCommitId: dd42206f86a7b9f7747ccb63fa0e36baaab5fa1e
    appendedCacheKey: d817028e1760c31609f9e53637b20f8ddde03229611a26d440364f0eceb7219e
    doNotCacheOnWorkflowFailure: true
    vcpkgDirectory: D:\a\libtremotesf\libtremotesf/vcpkg
    runVcpkgInstall: false
    vcpkgGitURL: https://github.com/microsoft/vcpkg.git
    doNotUpdateVcpkg: false
    doNotCache: false
    vcpkgJsonGlob: **/vcpkg.json
    vcpkgJsonIgnores: ['**/vcpkg/**']
    runVcpkgFormatString: [`install`, `--recurse`, `--clean-after-build`, `--x-install-root`, `$[env.VCPKG_INSTALLED_DIR]`, `--triplet`, `$[env.VCPKG_DEFAULT_TRIPLET]`]
    useShell: true
    logCollectionRegExps: \s*"(.+CMakeOutput\.log)"\.\s*;\s*"(.+CMakeError\.log)"\.\s*;\s*(.+out\.log)\s*;\s+(.+err\.log)\s*;\s*(.+vcpkg.+\.log)\s*
    jobStatus: success

Could it be related to the fact that I use it from composite action?

[lukka]

@equeim By inspecting the code the message you mentioned is only outputted when doNotCache is false. The value of doNotCacheOnWorkflowFailure should not be important. We could validate all those assertions by looking into the complete log with verbose output.

Could you confirm whether this looks correct?

[equeim]

Hmm. I took another look at the action code, and it looks like that constructor arguments for VcpkgPostAction class are in the wrong order:

run-vcpkg/src/post-action.ts

Line 26 in 45ca959

jobSucceeded, doNotCache, doNotCacheOnWorkflowFailure,

and

run-vcpkg/src/vcpkg-post-action.ts

Line 14 in 45ca959

private doNotCacheOnWorkflowFailure: boolean,

(doNotCacheOnWorkflowFailure and doNotCache are mixed up).

[lukka]

Fixed in #126 , please try run-vcpkg@v10.1 and let me know!

[equeim]

It seems that doNotCacheOnWorkflowFailure is removed in 10.1. Does this mean that there is now no way to disable cache saving when workflow fails?

[lukka]

@equeim right, it was removed because the detection of the job status in the post action never worked.
Please refer to #115 for a similar discussion.

The way it works now is as follows:

• run-vcpkg succeeded
  • if cache-hit then skip saving cache
  • if cache-miss, then save cache (and if the cache was partially created, it will be saved anyway).
• run-vcpkg failed or did not execute
  • no cache saved

Opened #128 about solving this.