Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use while loop #29

Merged
merged 1 commit into from Oct 27, 2021
Merged

Use while loop #29

merged 1 commit into from Oct 27, 2021

Conversation

rohit2sharma95
Copy link
Contributor

Closes #28

Although, it is a highly opinionated thing.

@codecov-commenter
Copy link

Codecov Report

Merging #29 (fd89f97) into master (6515792) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           34        34           
=========================================
  Hits            34        34           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6515792...fd89f97. Read the comment docs.

@lukeed lukeed merged commit fa0f75c into lukeed:master Oct 27, 2021
lukeed added a commit that referenced this pull request Oct 27, 2021
@rohit2sharma95 rohit2sharma95 deleted the rs/while-loop branch October 27, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: why did you not choose the while loop?
3 participants