Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to resolve package names with '@' #7

Closed
Qfengx opened this issue Jan 20, 2022 · 5 comments · Fixed by #36
Closed

[BUG] Unable to resolve package names with '@' #7

Qfengx opened this issue Jan 20, 2022 · 5 comments · Fixed by #36
Assignees
Labels
monaco-issue An issue with monaco that we cannot fix ourselves.

Comments

@Qfengx
Copy link

Qfengx commented Jan 20, 2022

I think it should be caused by encoding the package name path when parsing the uri.
use "import * as sdk '@weapp/ecodesdk'" is not ok.
image
you can see , " import * as sdk from '%40weapp/ecodesdk'" is ok.
image

@Qfengx Qfengx added the bug Something isn't working label Jan 20, 2022
@lukasbach
Copy link
Owner

Hi @Qfengx! This is a known bug (https://github.com/lukasbach/monaco-editor-auto-typings#known-limitations), which is caused by an issue on the side of monaco-editor (microsoft/monaco-editor#2295). Scoped packages are currently not supported because of this.

@lukasbach lukasbach added monaco-issue An issue with monaco that we cannot fix ourselves. and removed bug Something isn't working labels Mar 15, 2022
@bsorrentino
Copy link

Hi @lukasbach

Thanks for your amazing work

I've worked trying to understand the problem and finally I found out.

I've submitted this PR to monaco-editor hoping it will be approved and merged soon

bsorrentino added a commit to bsorrentino/monaco-editor-auto-typings that referenced this issue Apr 4, 2022
@lukasbach
Copy link
Owner

@bsorrentino Thank you for your effort in investigating this and proposing a fix :)

I'm very much hoping for it to get merged on monaco-editor.

bsorrentino added a commit to bsorrentino/monaco-editor-auto-typings that referenced this issue Apr 17, 2022
@nirtamir2
Copy link

nirtamir2 commented Mar 14, 2023

@lukasbach It seems like the Monaco issue microsoft/monaco-editor#2295 is marked as completed.

@FreePhoenix888
Copy link

@lukasbach It seems like the Monaco issue microsoft/monaco-editor#2295 is marked as completed.

@lukasbach ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco-issue An issue with monaco that we cannot fix ourselves.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants