Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DynamoDb v2 API #230

Merged
merged 12 commits into from
Apr 12, 2020
Merged

Support for DynamoDb v2 API #230

merged 12 commits into from
Apr 12, 2020

Conversation

lukas-krecan
Copy link
Owner

No description provided.

mark-egan-calabrio and others added 7 commits April 11, 2020 19:33
…amodb-legacy.

Re-implemented shedlock-provider-dynamodb to use AWS SDK2 of DynamoDB client.
Changed HsqlJdbcTemplateLockProviderIntegrationTest to use TimeZone.getDefault() as it wasn't working in my timezone.
Upping version to 5.0.0-SNAPSHOT as migrating shedlock-provider-dynamodb and introduction of shedlock-provider-dynamodb-legacy are breaking changes.
Updated README.md with usage for both the newly implemented and legacy DynamoDB providers.
while keeping current implementation in current module
@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #230 into master will increase coverage by 0.92%.
The diff coverage is 98.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
+ Coverage     85.91%   86.84%   +0.92%     
- Complexity      310      319       +9     
============================================
  Files            61       65       +4     
  Lines          1193     1292      +99     
  Branches         69       69              
============================================
+ Hits           1025     1122      +97     
- Misses          146      148       +2     
  Partials         22       22              
Impacted Files Coverage Δ Complexity Δ
...mbs/shedlock/provider/dynamodb2/DynamoDBUtils.java 93.33% <93.33%> (ø) 1.00 <1.00> (?)
...edlock/provider/dynamodb/DynamoDBLockProvider.java 100.00% <100.00%> (ø) 3.00 <0.00> (?)
...dlock/provider/dynamodb2/DynamoDBLockProvider.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...umbs/shedlock/provider/dynamodb/DynamoDBUtils.java 87.50% <0.00%> (ø) 1.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c67228...08a60e7. Read the comment docs.

@lukas-krecan lukas-krecan merged commit f6fe527 into master Apr 12, 2020
@lukas-krecan lukas-krecan deleted the dyn2 branch April 12, 2020 07:56
@xmrk
Copy link

xmrk commented Apr 12, 2020

Excellent, thanks! Sorry I got overly ambitious with the module name and version. I look forward to getting this released.

@lukas-krecan
Copy link
Owner Author

Released as 4.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants