Default to 1.7-level bytecode in Java build #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
tenderlove
added a commit
to bcrypt-ruby/bcrypt-ruby
that referenced
this pull request
Jul 21, 2020
tenderlove
added a commit
to bcrypt-ruby/bcrypt-ruby
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rake-compiler defaults to source level and output bytecode version 1.6, corresponding to Java 1.6.
JRuby has not supported 1.6 since the release of JRuby 9.0, five years ago, when we started requiring Java 7.
This PR updates the default versions to "1.7" level for Java 7.
All current supported versions of JRuby require Java 8, but I'm ok with using 1.7 here for any 9.0 stragglers.