Improved performance of Pipeline.exec #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVVS
reviewed
Oct 12, 2019
| if (!buffers) { | ||
| buffers = []; | ||
| } | ||
| if (typeof data === "string") { |
There was a problem hiding this comment.
Data is ignored if its already a buffer
There was a problem hiding this comment.
data cannot be a Buffer. I cleaned up the code a bit to make this clear.
Your comment made me aware that buffers is actually never re-set, so I did that, too.
|
LGTM, @luin if you are ok with the PR I'd be happy to merge :) |
|
I'll merge this in, I believe releases are going through /next tag and it should be safe |
ioredis-robot
pushed a commit
that referenced
this pull request
Nov 22, 2019
## [4.14.4](v4.14.3...v4.14.4) (2019-11-22) ### Bug Fixes * improved performance of Pipeline.exec ([#991](#991)) ([86470a8](86470a8))
|
🎉 This PR is included in version 4.14.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you for merging this! I totally missed this pull request. The code LGTM. |
This was referenced Jan 16, 2020
This was referenced Jan 24, 2020
This was referenced Feb 22, 2020
This was referenced Mar 19, 2020
This was referenced Apr 17, 2020
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.14.4](redis/ioredis@v4.14.3...v4.14.4) (2019-11-22) ### Bug Fixes * improved performance of Pipeline.exec ([#991](redis/ioredis#991)) ([86470a8](redis/ioredis@86470a8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution cost of Pipeline.exec can be reduced to 50% or lower. This is
accomplished by first filling up an Array of Buffers and then calling
Buffer.concatinstead of calling
Buffer.concatfor each command.In our use-case (~3000 commands in a single Pipeline) wall-clock-runtime went
down from 1.3sec to 500ms.