Run prettier

[imatlopez]

No description provided.

[imatlopez]

@luin using defaults to prettier, but I don't know if making line width 120 better, or using single quotes.

[imatlopez]

should src be added to the bundle in case people want to use the raw typings?

[luin]

using defaults to prettier, but I don't know if making line width 120 better, or using single quotes.

I suggest sticking with the default settings of Prettier as close as possible since these settings are adopted by more people, making it easier for them to contribute to ioredis. (Although personally, I prefer to omit semicolons 🤣 .)

should src be added to the bundle in case people want to use the raw typings?

Declarations will be included in the bundle if declaration is set to true in the tsconfig.json, so we don't need to bundle src into the package.

However, there is still something to do before bundling the declarations. The major one is Redis command methods are not declared, so TypeScript will complain about the usage like redis.get(xxx).. I'm already working on a solution for it, and after that, we can provide the official declarations.

[imatlopez]

@luin cool, in the meantime travis passed but seems the reporting hanged, and also I am attempting to use 4.11 on my end but there seems to be an issue with the asCallback in the Redis.connect function. :( good thing it is tagged as next for now

[luin]

I am attempting to use 4.11 on my end but there seems to be an issue with the asCallback in the Redis.connect function.

What issue did you encountered?

[imatlopez]

Can't seem to connect, also I see some unhandled promise rejections now that we switched to promises

[ioredis-robot]

🎉 This issue has been resolved in version 4.11.1 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[ioredis-robot]

🎉 This PR is included in version 4.11.2 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀