Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 18 to CI #1655

Merged
merged 1 commit into from Oct 29, 2022
Merged

Add node 18 to CI #1655

merged 1 commit into from Oct 29, 2022

Conversation

silverwind
Copy link
Contributor

Let's see how this goes.

@TysonAndre
Copy link
Collaborator

I'm not familiar with this project's test strategy but this looks reasonable with node 18 LTS starting October 25th

Unrelatedly, I see redis 7.0 stable was recently released.

Also, a question for other maintainers: I've used include in other projects to reduce the number of jobs while allowing testing more combinations without a large number of excludes. Would it make sense to start testing more redis versions with this?

matrix:
  include:
    - node: 12.x
      redis: '2'
    - node: 12.x
      redis: '6'
    - node: 12.x
      redis: '7'
      # ...

@TysonAndre TysonAndre merged commit 4de8cdb into redis:main Oct 29, 2022
@silverwind silverwind deleted the node-18 branch October 30, 2022 10:02
@luin
Copy link
Collaborator

luin commented Oct 31, 2022

Also, a question for other maintainers: I've used include in other projects to reduce the number of jobs while allowing testing more combinations without a large number of excludes. Would it make sense to start testing more redis versions with this?

@TysonAndre You mean only test all Redis versions with only one Node.js version? That does make sense to me but I'm okay with 4 (Node.js versions) * 3 (Redis versions) so I think we can stay without using include.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

🎉 This PR is included in version 5.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants