Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dependencie 'p-map' require node >= 10 #1216

Closed
Zhouxingzu opened this issue Oct 27, 2020 · 6 comments · Fixed by #1224
Closed

The dependencie 'p-map' require node >= 10 #1216

Zhouxingzu opened this issue Oct 27, 2020 · 6 comments · Fixed by #1224
Labels

Comments

@Zhouxingzu
Copy link

I find that i can't run it in my project, my node is 6, is it caused by this problem?

@ShogunPanda
Copy link
Contributor

Yes, I introduced this dependency in #1201 in order to send scripts to the server in controlled way.
Node 6 has gone End Of Life, I advice to updated it if you can.

@AVVS AVVS added the wontfix label Oct 28, 2020
@Zhouxingzu
Copy link
Author

Yes, I introduced this dependency in #1201 in order to send scripts to the server in controlled way.
Node 6 has gone End Of Life, I advice to updated it if you can.

Thanks, bro, I see README mentioned (Node.js >= 6) before. I will update my node

@NicoZelaya
Copy link

NicoZelaya commented Oct 29, 2020

The readme should be fixed then and this should be considered a breaking change.

Jumping from Node 6 as minimum version to Node 10 is somewhat unexpected for a minor release given this is not just new functionality but an actual breaking change.

@AVVS
Copy link
Collaborator

AVVS commented Oct 29, 2020

@ShogunPanda any chance you'd be able to replace p-map with an utility that supports node 6+ ? I agree with comments re: breaking change, even though nodejs 6 is no longer supported at all

@ShogunPanda
Copy link
Contributor

Yes, I can just downgrade p-map to ^2.1.0, which is the last one that supports Node 6.

Also, I'm gonna change the Travis conf to run against all supported Node versions.

ioredis-robot pushed a commit that referenced this issue Oct 31, 2020
## [4.19.2](v4.19.1...v4.19.2) (2020-10-31)

### Bug Fixes

* Fix autopipeline and downgrade p-map to support Node 6. [[#1216](#1216)] ([1bc8ca0](1bc8ca0))
@ioredis-robot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this issue Mar 1, 2024
## [4.19.2](redis/ioredis@v4.19.1...v4.19.2) (2020-10-31)

### Bug Fixes

* Fix autopipeline and downgrade p-map to support Node 6. [[#1216](redis/ioredis#1216)] ([1bc8ca0](redis/ioredis@1bc8ca0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants