Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds auth support for Redis 6 #1130

Merged
merged 5 commits into from May 16, 2020
Merged

Adds auth support for Redis 6 #1130

merged 5 commits into from May 16, 2020

Conversation

asyrique
Copy link
Contributor

@asyrique asyrique commented May 10, 2020

This PR contains the following changes:

Fixes #1097

@asyrique
Copy link
Contributor Author

@luin This should be ready to be reviewed.
I didn't know whether this merited a patch version bump or a minor version bump, so defer to you on that.

Let me know if there's anything I need to fix in this PR.

@asyrique
Copy link
Contributor Author

@luin Is there anything I can change / help to do that can help get this merged? I think I've covered all of the cases in the tests I wrote, but if there's a test case I missed out, if you can describe the case, I can write a test for it.

Thanks and appreciate all the work you do to keep this library fast and secure!

lib/utils/index.ts Outdated Show resolved Hide resolved
lib/redis/index.ts Outdated Show resolved Hide resolved
@luin
Copy link
Collaborator

luin commented May 13, 2020

Sorry for the late response. Code-wise it looks good to me 👍, just left two comments. I'll test thoroughly and merge the PR this weekend.

asyrique and others added 2 commits May 13, 2020 22:01
Co-authored-by: Zihua Li <i@zihua.li>
@luin luin merged commit ad5b455 into redis:master May 16, 2020
ioredis-robot pushed a commit that referenced this pull request May 16, 2020
# [4.17.0](v4.16.3...v4.17.0) (2020-05-16)

### Features

* add auth support for Redis 6 ([#1130](#1130)) ([ad5b455](ad5b455))
@ioredis-robot
Copy link
Collaborator

🎉 This PR is included in version 4.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this pull request Mar 1, 2024
# [4.17.0](redis/ioredis@v4.16.3...v4.17.0) (2020-05-16)

### Features

* add auth support for Redis 6 ([#1130](redis/ioredis#1130)) ([ad5b455](redis/ioredis@ad5b455))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Auth with username & password (Redis 6)
3 participants