Ignore empty hosts returned by CLUSTER SLOTS #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
|
🎉 This PR is included in version 4.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 16, 2020
This was referenced Jan 24, 2020
This was referenced Feb 22, 2020
This was referenced Mar 13, 2020
This was referenced Mar 20, 2020
This was referenced Apr 17, 2020
slestang
pushed a commit
to EasyMile/redix-cluster
that referenced
this pull request
Sep 28, 2020
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.15.1](redis/ioredis@v4.15.0...v4.15.1) (2019-12-25) ### Bug Fixes * ignore empty hosts returned by CLUSTER SLOTS ([#1025](redis/ioredis#1025)) ([d79a8ef](redis/ioredis@d79a8ef)) * prevent exception when send custom command ([04cad7f](redis/ioredis@04cad7f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some nodes disconnected from the cluster, there will be left with some empty addresses.
Then the
CLUSTER SLOTSwill reply with empty hosts.ioredisthen convert the empty address:0to127.0.0.1:6379internally and try to connect them.Even worse, when
scaleReads=='slaves', it may try to sendCommand to:0.So we'd better just ignore these empty addresses.