Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorflow 1.15.2 is built with separate cpu-gpu packages #633

Closed
carlogrisetti opened this issue Feb 12, 2020 · 5 comments
Closed

Tensorflow 1.15.2 is built with separate cpu-gpu packages #633

carlogrisetti opened this issue Feb 12, 2020 · 5 comments
Labels
bug Something isn't working looking into it

Comments

@carlogrisetti
Copy link
Contributor

Requirements were bumped to 1.15.2, but in 1.15.2 (and upwards most likely) cpu and gpu packages were separated once again, due to the discovery of an unsupported workaround to deploy packages on Pypi. Please refer to: tensorflow/tensorflow#36347

You should decide whether to require a previous version, or whether to reinclude instructions to choose between tensorflow and tensorflow-gpu packages as in old fashioned ludwig setup info by first uninstalling tensorflow and then reinstalling tensorflow-gpu==1.15.2

@w4nderlust
Copy link
Collaborator

Oh my, I though i was done with this... :(

@w4nderlust w4nderlust added bug Something isn't working looking into it labels Feb 12, 2020
@carlogrisetti
Copy link
Contributor Author

Heh... They basically messed up with the way they generated the packages.
If I understood correctly, however, tensorflow-gpu should also cover cpu usage. It might be worth a test. They were renaming tensorflow to tensorflow-cpu and tensorflow-gpu to tensorflow (so this should be the one now supporting any architecture)

@carlogrisetti
Copy link
Contributor Author

In the meantime, I can confirm that tensorflow-gpu is correctly working on a non-gpu machine.
PR #635 might be modified to always have tensorflow-gpu in the requirements since it should handle both gpu and non-gpu environments.
I could only test that on a windows machine (both GPU and non-GPU), so I can't vouch for other OSs

@w4nderlust
Copy link
Collaborator

I tested it by specifying CUDA_VISIBLE_DEVICES='' and it works reverting to CPU computation. i'm not aware of other drawbacks of using the GPU version, so i updated the PR to reflect this.

@w4nderlust
Copy link
Collaborator

Merged #635 which fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working looking into it
Projects
None yet
Development

No branches or pull requests

2 participants