use go run for mockgen, goimports and ginkgo
#3616
Conversation
Works without go install and uses the version in go.mod
internal/mocks/mockgen.go
Outdated
| //go:generate sh -c "mockgen -package mockackhandler -destination ackhandler/sent_packet_handler.go github.com/lucas-clemente/quic-go/internal/ackhandler SentPacketHandler" | ||
| //go:generate sh -c "mockgen -package mockackhandler -destination ackhandler/received_packet_handler.go github.com/lucas-clemente/quic-go/internal/ackhandler ReceivedPacketHandler" | ||
| //go:generate sh -c "go run github.com/golang/mock/mockgen -package mockquic -destination quic/stream.go github.com/lucas-clemente/quic-go Stream" | ||
| //go:generate sh -c "go run github.com/golang/mock/mockgen -package mockquic -destination quic/early_conn_tmp.go github.com/lucas-clemente/quic-go EarlyConnection && sed 's/qtls.ConnectionState/quic.ConnectionState/g' quic/early_conn_tmp.go > quic/early_conn.go && rm quic/early_conn_tmp.go && goimports -w quic/early_conn.go" |
There was a problem hiding this comment.
Should we do the same for goimports?
There was a problem hiding this comment.
Yeaaah I was just about to suggest that. And ginkgo?
There was a problem hiding this comment.
And ginkgo?
You mean in CI setup? sgtm
There was a problem hiding this comment.
Yeah, ginkgo doesn't really matter since I think go install uses the version in go.mod? But might as well.
Codecov ReportBase: 85.48% // Head: 85.50% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3616 +/- ##
==========================================
+ Coverage 85.48% 85.50% +0.01%
==========================================
Files 140 141 +1
Lines 10271 10293 +22
==========================================
+ Hits 8780 8800 +20
- Misses 1106 1108 +2
Partials 385 385
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marten-seemann
changed the title
go run for mockgengo run for mockgen, goimports and ginkgo
Works without go install and uses the (pinned) version in go.mod