Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a sync.Pool for ACK frames #3547

Merged
merged 2 commits into from Sep 9, 2022
Merged

use a sync.Pool for ACK frames #3547

merged 2 commits into from Sep 9, 2022

Conversation

marten-seemann
Copy link
Member

Closes #2885.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 85.50% // Head: 85.41% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (63764c4) compared to base (62b8278).
Patch coverage: 66.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3547      +/-   ##
==========================================
- Coverage   85.50%   85.41%   -0.09%     
==========================================
  Files         138      139       +1     
  Lines       10241    10266      +25     
==========================================
+ Hits         8756     8768      +12     
- Misses       1102     1114      +12     
- Partials      383      384       +1     
Impacted Files Coverage Δ
internal/logutils/frame.go 59.26% <0.00%> (-40.74%) ⬇️
connection.go 77.00% <60.00%> (-0.09%) ⬇️
internal/ackhandler/received_packet_history.go 96.43% <100.00%> (-0.24%) ⬇️
internal/ackhandler/received_packet_tracker.go 86.21% <100.00%> (+0.32%) ⬆️
internal/wire/ack_frame.go 94.78% <100.00%> (ø)
internal/wire/ack_frame_pool.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit d1d9f49 into master Sep 9, 2022
@marten-seemann marten-seemann deleted the pool-ack-frames branch October 9, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants