Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return an error when parsing a too long connection ID from a header #3533

Merged
merged 1 commit into from Aug 30, 2022

Conversation

marten-seemann
Copy link
Member

Fixes #3532.

@marten-seemann marten-seemann added this to the v0.30.0 milestone Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 85.56% // Head: 85.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f41772c) compared to base (3f1adfd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3533   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         137      137           
  Lines       10087    10089    +2     
=======================================
+ Hits         8630     8632    +2     
  Misses       1080     1080           
  Partials      377      377           
Impacted Files Coverage Δ
internal/wire/header.go 87.88% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit 3199560 into master Aug 30, 2022
@marten-seemann marten-seemann deleted the catch-conn-id-len-errors branch August 30, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: invalid conn id length
2 participants