Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a struct containing an array to represent Connection IDs #3529

Merged
merged 7 commits into from Aug 29, 2022

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Aug 28, 2022

Fixes #3527. Depends on #3528.

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Base: 85.66% // Head: 85.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4cbb4f8) compared to base (ec9c824).
Patch coverage: 89.17% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3529      +/-   ##
==========================================
- Coverage   85.66%   85.66%   -0.00%     
==========================================
  Files         137      137              
  Lines       10029    10070      +41     
==========================================
+ Hits         8591     8626      +35     
- Misses       1063     1067       +4     
- Partials      375      377       +2     
Impacted Files Coverage Δ
internal/wire/new_connection_id_frame.go 94.29% <ø> (-0.31%) ⬇️
qlog/trace.go 90.91% <ø> (ø)
qlog/types.go 84.46% <ø> (-0.08%) ⬇️
server.go 79.59% <60.00%> (-1.57%) ⬇️
packet_handler_map.go 72.37% <85.71%> (ø)
internal/protocol/connection_id.go 83.78% <89.29%> (+8.78%) ⬆️
connection.go 77.64% <91.67%> (ø)
internal/wire/version_negotiation.go 92.00% <92.31%> (+7.38%) ⬆️
conn_id_generator.go 93.10% <100.00%> (ø)
conn_id_manager.go 93.18% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann force-pushed the conn-id-array branch 2 times, most recently from 429d4d6 to dd941d6 Compare August 28, 2022 18:19
@marten-seemann marten-seemann added this to the v0.30.0 milestone Aug 28, 2022
internal/protocol/connection_id.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use a more efficient type for Connection IDs
2 participants