add a function to distinguish between long and short header packets #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3498 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 136 136
Lines 10025 10025
=======================================
Hits 8596 8596
Misses 1051 1051
Partials 378 378
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
marten-seemann
force-pushed
the
is-long-header
branch
from
f61f61b
to
015ae66
Compare
lucas-clemente
approved these changes
Aug 10, 2022
| @@ -73,7 +74,7 @@ var _ = Describe("Datagram test", func() { | |||
| return false | |||
| } | |||
| // don't drop Long Header packets | |||
| if packet[0]&0x80 == 1 { | |||
There was a problem hiding this comment.
Fwiw, the old version here was incorrect.
There was a problem hiding this comment.
I don't think so, this is selecting long header packets?
There was a problem hiding this comment.
Now I see it. It would have to be &0x80 == 0x80. Nice one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change expected.
Logically, this function belongs into the
wirepackage.