Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Go 1.16 and 1.17 #3482

Merged
merged 1 commit into from Aug 10, 2022
Merged

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Jul 25, 2022

This is in draft status until Go 1.19 is released.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3482 (0d102b5) into master (d5efd34) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 0d102b5 differs from pull request most recent head 34a403a. Consider uploading reports for the commit 34a403a to get more accurate results

@@            Coverage Diff             @@
##           master    #3482      +/-   ##
==========================================
+ Coverage   85.70%   85.75%   +0.05%     
==========================================
  Files         138      136       -2     
  Lines       10049    10025      -24     
==========================================
- Hits         8612     8596      -16     
+ Misses       1060     1051       -9     
- Partials      377      378       +1     
Impacted Files Coverage Δ
internal/qtls/go118.go 58.33% <ø> (ø)
internal/qtls/go119.go 58.33% <ø> (ø)
sys_conn_df_linux.go 52.94% <ø> (ø)
sys_conn_df_windows.go 52.94% <ø> (ø)
sys_conn_oob.go 71.88% <ø> (ø)
sys_conn_windows.go 62.50% <ø> (ø)
qlog/qlog.go 90.36% <0.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marten-seemann marten-seemann force-pushed the drop-go116-and-go117 branch 2 times, most recently from 28266cd to 5ebd8a1 Compare August 2, 2022 18:47
@marten-seemann marten-seemann marked this pull request as ready for review August 2, 2022 18:50
@marten-seemann
Copy link
Member Author

Go 1.19 was released earlier today: https://go.dev/doc/go1.19. 🎉

@lucas-clemente, can you please review?

README.md Outdated Show resolved Hide resolved
@marmeladema
Copy link

Support for Go 1.19 would be really helpful! Thank you for doing this.

@marten-seemann marten-seemann merged commit ea9de26 into master Aug 10, 2022
@marten-seemann marten-seemann deleted the drop-go116-and-go117 branch August 15, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants