Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't ignore errors that occur when the TLS ClientHello is generated #3424

Merged
merged 3 commits into from May 20, 2022

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 20, 2022

Recreating #3420 due to wrong merge method used there. Fixes #3419.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #3424 (2e98150) into master (2e98150) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e98150 differs from pull request most recent head 53be3ee. Consider uploading reports for the commit 53be3ee to get more accurate results

@@           Coverage Diff           @@
##           master    #3424   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files         136      136           
  Lines        9928     9928           
=======================================
  Hits         8480     8480           
  Misses       1066     1066           
  Partials      382      382           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e98150...53be3ee. Read the comment docs.

@marten-seemann marten-seemann merged commit 8185d1b into master May 20, 2022
@marten-seemann marten-seemann deleted the fix-tls-error-handling2 branch May 22, 2022 17:30
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not every crypto/tls error generates an alert
1 participant