Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a http3.RoundTripOpt to prevent closing of request stream #3411

Merged
merged 1 commit into from May 20, 2022

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 13, 2022

Fixes #3396.

cc @hareku

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3411 (1a31fb6) into master (60bbe92) will decrease coverage by 0.02%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #3411      +/-   ##
==========================================
- Coverage   85.37%   85.36%   -0.02%     
==========================================
  Files         135      136       +1     
  Lines        9928     9931       +3     
==========================================
+ Hits         8476     8477       +1     
- Misses       1067     1069       +2     
  Partials      385      385              
Impacted Files Coverage Δ
http3/conn.go 0.00% <0.00%> (ø)
http3/client.go 82.16% <66.67%> (-0.10%) ⬇️
http3/request_writer.go 63.19% <100.00%> (+0.52%) ⬆️
http3/roundtrip.go 93.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60bbe92...1a31fb6. Read the comment docs.

@marten-seemann marten-seemann merged commit de5f081 into master May 20, 2022
@marten-seemann marten-seemann deleted the dont-close-stream-roundtrip-opt branch May 23, 2022 17:40
marten-seemann added a commit that referenced this pull request May 29, 2022
This was accidentally commited in #3411.
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
This was accidentally commited in quic-go#3411.
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
This was accidentally commited in quic-go#3411.
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional close a Sending Stream for http3.RoundTripper
2 participants