remove warning comments of stable implementation #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hareku
force-pushed
the
remove-warning-comments
branch
from
f0b9bf8
to
8c0a383
Compare
Codecov Report
@@ Coverage Diff @@
## master #3399 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 135 135
Lines 9928 9928
=======================================
Hits 8475 8475
Misses 1068 1068
Partials 385 385 Continue to review full report at Codecov.
|
interface.go
Outdated
| Context() context.Context | ||
| // ConnectionState returns basic details about the QUIC connection. | ||
| // It blocks until the handshake completes. | ||
| // Warning: This API should not be considered stable and might change soon. |
There was a problem hiding this comment.
Don't remove this one please.
hareku
force-pushed
the
remove-warning-comments
branch
from
8c0a383
to
90d182a
Compare
marten-seemann
approved these changes
May 5, 2022
nmldiegues
pushed a commit
to chungthuang/quic-go
that referenced
this pull request
Jun 6, 2022
41 tasks
sudarshan-reddy
pushed a commit
to sudarshan-reddy/quic-go
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were implemented 4 or 5 years ago, so they actually seem to be stable.
git blame: https://github.com/lucas-clemente/quic-go/blame/master/interface.go