remove nextdns from list of projects using quic-go #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: github.com/nextdns/nextdns/commit/538d0a85
|
Thanks! Any idea why they dropped quic-go? |
marten-seemann
changed the title
marten-seemann
approved these changes
Mar 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #3363 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 135 135
Lines 9869 9869
=======================================
Hits 8449 8449
Misses 1043 1043
Partials 377 377 Continue to review full report at Codecov.
|
|
I guess, the exotic nature of the protocol itself is the reason why: nextdns/nextdns#658 (comment) |
|
Oh well, #765 again... |
nmldiegues
pushed a commit
to chungthuang/quic-go
that referenced
this pull request
Jun 6, 2022
ref: github.com/nextdns/nextdns/commit/538d0a85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: github.com/nextdns/nextdns/commit/538d0a85