Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the Session to Connection #3361

Merged
merged 13 commits into from Mar 27, 2022
Merged

rename the Session to Connection #3361

merged 13 commits into from Mar 27, 2022

Conversation

marten-seemann
Copy link
Member

The term "session" is a remnant from gQUIC days. The QUIC RFC doesn't talk about "sessions", only about connections.

Note that this will be a quite disruptive change for downstream users.

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #3361 (4b17343) into master (42f3159) will not change coverage.
The diff coverage is 84.91%.

@@           Coverage Diff           @@
##           master    #3361   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         135      135           
  Lines        9869     9869           
=======================================
  Hits         8449     8449           
  Misses       1043     1043           
  Partials      377      377           
Impacted Files Coverage Δ
http3/roundtrip.go 93.33% <ø> (ø)
multiplexer.go 94.44% <ø> (ø)
sys_conn.go 84.62% <ø> (ø)
sys_conn_df_linux.go 52.94% <ø> (ø)
sys_conn_df_windows.go 52.94% <ø> (ø)
sys_conn_oob.go 71.88% <ø> (ø)
sys_conn_windows.go 62.50% <ø> (ø)
closed_conn.go 79.41% <33.33%> (ø)
send_conn.go 47.37% <50.00%> (ø)
http3/server.go 73.24% <81.25%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f3159...4b17343. Read the comment docs.

Copy link
Member

@lucas-clemente lucas-clemente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want any disambiguation from all the conn_* files? With this, we use "conn" for both classes of connections we have. (Maybe rename the conn_* stuff to rawConn, udpConn, sysConn?)

@marten-seemann marten-seemann merged commit d008a25 into master Mar 27, 2022
@marten-seemann marten-seemann deleted the rename-session branch March 27, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants