improve code coverage of random number generator test #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3358 +/- ##
==========================================
+ Coverage 85.57% 85.58% +0.01%
==========================================
Files 135 135
Lines 9860 9860
==========================================
+ Hits 8437 8438 +1
+ Misses 1046 1045 -1
Partials 377 377
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it more likely that https://github.com/lucas-clemente/quic-go/blob/d4293fb274084bc8fda54d39941c1856cf00d3ed/internal/utils/rand.go#L25-L27 is executed, as the value
maxis reduced by passing in a highern.