Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move set DF implementation to separate files & avoid the need for OOBCapablePacketConn #3334

Merged
merged 2 commits into from Mar 7, 2022
Merged

move set DF implementation to separate files & avoid the need for OOBCapablePacketConn #3334

merged 2 commits into from Mar 7, 2022

Conversation

tobyxdd
Copy link
Contributor

@tobyxdd tobyxdd commented Feb 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2022 •
edited

Codecov Report

Merging #3334 (0467a29) into master (fd2c345) will decrease coverage by 0.09%.
The diff coverage is 53.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3334      +/-   ##
==========================================
- Coverage   85.61%   85.52%   -0.09%     
==========================================
  Files         136      135       -1     
  Lines        9808     9828      +20     
==========================================
+ Hits         8397     8405       +8     
- Misses       1036     1046      +10     
- Partials      375      377       +2
Impacted Files Coverage Δ
conn_oob.go 71.88% <ø> (-0.22%) ⬇️
conn_windows.go 62.50% <ø> (+3.68%) ⬆️
conn_df_linux.go 52.94% <52.94%> (ø)
conn_df_windows.go 52.94% <52.94%> (ø)
conn.go 84.62% <55.56%> (-15.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2c345...0467a29. Read the comment docs.

marten-seemann
marten-seemann reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can we merge the err_size_.go files with the conn_df_.go files?

You'll also need to run gofumpt (probably gofmt would be enough), CI is unhappy with the imports.

@marten-seemann marten-seemann merged commit ad1cb27 into quic-go:master Mar 7, 2022
@bt90 bt90 mentioned this pull request Mar 24, 2022
Merged
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
@tobyxdd @nmldiegues
move set DF implementation to separate files & avoid the need for OOB…
59b83f1 
…CapablePacketConn (quic-go#3334)

* move set DF implementation to separate files & avoid the need for OOBCapablePacketConn

* merge err_size_* into conn_df_* & fix format
@renovate renovate bot mentioned this pull request Sep 23, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobyxdd @marten-seemann