Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qerr: include role (remote / local) in error string representations #3629

Merged
merged 1 commit into from Dec 8, 2022

Conversation

marten-seemann
Copy link
Member

This would fix libp2p/go-libp2p#1928. cc @MarcoPolo

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 85.49% // Head: 85.49% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fd35b1b) compared to base (8d496eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3629   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files         142      142           
  Lines       10300    10303    +3     
=======================================
+ Hits         8805     8808    +3     
  Misses       1110     1110           
  Partials      385      385           
Impacted Files Coverage Δ
internal/handshake/crypto_setup.go 66.74% <100.00%> (ø)
internal/qerr/error_codes.go 100.00% <100.00%> (ø)
internal/qerr/errors.go 91.18% <100.00%> (+0.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit d251219 into master Dec 8, 2022
@marten-seemann marten-seemann deleted the role-in-error-msg branch December 8, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quic: Error from peer should be explicit that it is coming from remote peer rather than a local error
2 participants