Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit the exponential PTO backoff to 60s #3595

Merged
merged 4 commits into from Nov 15, 2022
Merged

limit the exponential PTO backoff to 60s #3595

merged 4 commits into from Nov 15, 2022

Conversation

cliffc-spirent
Copy link
Contributor

resolves #3594

@google-cla
Copy link

google-cla bot commented Oct 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@marten-seemann marten-seemann mentioned this pull request Oct 16, 2022
Closed
marten-seemann
marten-seemann reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test please? :)

@cliffc-spirent
updating exponential backoff test for truncation
de80d4a 
fixed an issue where a large number of lost packets
would cause the scaled PTO to rollover/overflow to negative
and then zero

updating a related test that was using a large constant delay
and would run up against the new max pto limit
marten-seemann
marten-seemann approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need the CLA before we can merge this though.

@codecov
Copy link

codecov bot commented Oct 22, 2022 •
edited

Codecov Report

Base: 85.47% // Head: 85.49% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9ec71c1) compared to base (f78683a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3595      +/-   ##
==========================================
+ Coverage   85.47%   85.49%   +0.02%     
==========================================
  Files         140      142       +2     
  Lines       10267    10298      +31     
==========================================
+ Hits         8775     8804      +29     
- Misses       1107     1109       +2     
  Partials      385      385
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 78.57% <100.00%> (+0.20%) ⬆️
http3/body.go 78.57% <0.00%> (ø)
http3/capsule.go 81.82% <0.00%> (ø)
interface.go 0.00% <0.00%> (ø)
http3/client.go 90.50% <0.00%> (+0.04%) ⬆️
sys_conn_oob.go 72.73% <0.00%> (+0.42%) ⬆️
client.go 80.00% <0.00%> (+1.09%) ⬆️
send_queue.go 100.00% <0.00%> (+3.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann
Copy link
Member

@cliffc-spirent Friendly reminder that we still need the CLA.

@cliffc-spirent
Copy link
Contributor Author

@marten-seemann the current status is that the Chief Architect has met with the General Counsel and there are some more internal forms to fill out before the CEO gets to make final approval. I wish I was kidding.

@cliffc-spirent
Copy link
Contributor Author

CLA was submitted Friday, still waiting to hear back from Google.

@marten-seemann
Copy link
Member

@lucas-clemente can you please check the CLA?

@lucas-clemente
Copy link
Member

Forced a rescan, but nothing changed.

@cliffc-spirent
Copy link
Contributor Author

It looks like the CLA finally made its way through.

@marten-seemann marten-seemann changed the title limiting exponential pto delay to a constant limit the exponential PTO backoff to 60s Nov 15, 2022
marten-seemann
marten-seemann approved these changes Nov 15, 2022
View reviewed changes
internal/ackhandler/sent_packet_handler.go Outdated Show resolved Hide resolved
internal/ackhandler/sent_packet_handler.go Outdated Show resolved Hide resolved
@marten-seemann marten-seemann merged commit b844704 into quic-go:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No limit to exponential growth of PTO
3 participants
@cliffc-spirent @marten-seemann @lucas-clemente