Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env to disable the receive buffer warning #3339

Merged
merged 1 commit into from Mar 7, 2022

Conversation

arashpayan
Copy link
Contributor

If the env QUIC_GO_DISABLE_RECEIVE_BUFFER_WARNING is set to true
(as defined by strconv.ParseBool()), the receive buffer warning
will not be printed out.

Resolves #3338

If the env QUIC_GO_DISABLE_RECEIVE_BUFFER_WARNING is set to true
(as defined by strconv.ParseBool()), the receive buffer warning
will not be printed out.
@google-cla
Copy link

google-cla bot commented Mar 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@marten-seemann marten-seemann changed the title [#3338] Add env to disable the receive buffer warning add env to disable the receive buffer warning Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #3339 (bd9c5ca) into master (17952f3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3339      +/-   ##
==========================================
- Coverage   85.61%   85.61%   -0.01%     
==========================================
  Files         136      136              
  Lines        9808     9809       +1     
==========================================
  Hits         8397     8397              
  Misses       1036     1036              
- Partials      375      376       +1     
Impacted Files Coverage Δ
packet_handler_map.go 74.30% <0.00%> (-0.70%) ⬇️
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17952f3...bd9c5ca. Read the comment docs.

@marten-seemann marten-seemann merged commit fa070e5 into quic-go:master Mar 7, 2022
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
If the env QUIC_GO_DISABLE_RECEIVE_BUFFER_WARNING is set to true
(as defined by strconv.ParseBool()), the receive buffer warning
will not be printed out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling the receive buffer warning?
2 participants