Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic scrolling when selected area bigger than viewport height #119

Open
raspberryredrose opened this issue May 30, 2022 · 0 comments
Open

Comments

@raspberryredrose
Copy link

I am using ngx-guided-tour on my Angular project. In most cases, this works seamlessly. But I noticed the following issue:

If the selected area is bigger than the viewport height and I use Orientation.Left or Orientation.Right the page will be scrolled to the bottom of the selected area while the tour step remains next to the top of the selected area. Like this, the tour step is not visible anymore.

If I instead use Orientation.Top, the behavior is as expected. The page does not scroll to the bottom and the step is shown.

I would expect the same behavior when I use Orientation.Left or Orientation.Right since the step itself remains next to the top of the selected area.

This is how I configure the tour step:

const steps: TourStep[] = [{
    selector: '.some-class-that-is-bigger-than-the-viewport-height',
    content: 'some content',
    orientation: Orientation.Left
}];

Do you agree that this behavior is not as expected? If yes I could have a look at fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant