fix toc generation to properly nest #1288

mkamensky · 2019-11-11T15:30:47Z

Description

The js function the generates toc produces malformed html: <ol> elements occur within other <ol> elements directly. This change fixes it.

Completed Tasks

[x ] I have read the Contributing Guide.
[ x] The pull request is complete (implemented / written).
[x ] Git commits have been cleaned up (squash WIP / revert commits).
[x ] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

coveralls · 2019-11-11T15:35:03Z

Coverage decreased (-0.2%) to 93.598% when pulling a95018d on mkamensky:template-fix into 4b5c875 on lsegal:master.

lsegal · 2019-11-26T20:39:57Z

Thanks for the contribution!

References: #1196, #1220, #1242, #1244, #1245, #1258, #1260, #1262, #1263, #1269, #1274, #1276, #1284, #1288, #1290, #1294, #1297

fix toc generation to properly nest

a95018d

lsegal merged commit 6fc420c into lsegal:master Nov 26, 2019

lsegal added a commit that referenced this pull request Dec 31, 2019

Tag release v0.9.21

f13462d

References: #1196, #1220, #1242, #1244, #1245, #1258, #1260, #1262, #1263, #1269, #1274, #1276, #1284, #1288, #1290, #1294, #1297

mkamensky deleted the template-fix branch March 4, 2020 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix toc generation to properly nest #1288

fix toc generation to properly nest #1288

mkamensky commented Nov 11, 2019

Uh oh!

coveralls commented Nov 11, 2019 •

edited

Loading

Uh oh!

lsegal commented Nov 26, 2019

Uh oh!

fix toc generation to properly nest #1288

fix toc generation to properly nest #1288

Conversation

mkamensky commented Nov 11, 2019

Description

Completed Tasks

Uh oh!

coveralls commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsegal commented Nov 26, 2019

Uh oh!

coveralls commented Nov 11, 2019 •

edited

Loading