Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Module#namespace extension #1229

Merged
merged 1 commit into from Mar 31, 2019
Merged

Remove Module#namespace extension #1229

merged 1 commit into from Mar 31, 2019

Conversation

dduugg
Copy link
Contributor

@dduugg dduugg commented Mar 5, 2019 •
edited

Description

Module#namespace is removed as it is unused

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR). (I ran bundle exec rake but have not written tests.)

@coveralls
Copy link

coveralls commented Mar 5, 2019 •
edited

Coverage Status

Coverage increased (+0.09%) to 93.732% when pulling 886a51f on dduugg:dug-rm-namespace_name into 565343f on lsegal:master.

@lsegal lsegal merged commit 87ef6d8 into lsegal:master Mar 31, 2019
@lsegal
Copy link
Owner

lsegal commented Mar 31, 2019

Thanks!

lsegal added a commit that referenced this pull request Apr 2, 2019
@lsegal
Tag release v0.9.19
12f56cf 
References:
  #1071, #1198, #1219, #1226, #1228, #1229, #1231, #1233,
  #1234, #1235
This was referenced Mar 8, 2020
Closed
Merged
This was referenced Mar 12, 2021
Open
Open
@dduugg dduugg deleted the dug-rm-namespace_name branch August 25, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dduugg @coveralls @lsegal