Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser Back is not working #1071

Closed
thomthom opened this issue Feb 10, 2017 · 1 comment
Closed

Browser Back is not working #1071

thomthom opened this issue Feb 10, 2017 · 1 comment

Comments

@thomthom
Copy link
Contributor

If you click on a method which takes you to the anchor for that method then clicking Back in the browser doesn't take up back up where you were. (Tested in Chrome, Windows 10)

Steps to reproduce

This can be observed in the latest version (0.9.8). For instance, on this page for YARD itself; http://www.rubydoc.info/gems/yard/File (Generated by 0.9.8)

For instance, click on the cleanpath link under the "Manipulating Paths" section - then try the browser back button.

Actual Output

When clicking back after clicking an anchor nothing happens. If I keep clicking it will navigate back to whatever URL I was coming from, but anchor history is broken.

Expected Output

Expected behaviour would be for the browser history buttons to act upon the anchor history - like normally happens.

Environment details:

  • OS: Windows 10
  • YARD version (yard -v): 0.9.8
  • Relevant software dependency/versions:
    • Chrome 56.0.2924.87

I have read the Contributing Guide.
@nrser nrser mentioned this issue Apr 1, 2017
Closed
@noahgibbs
Copy link

I observe the same thing on Mac OS X v. 10.12.6 and Chrome 63.0.3239.84 64-bit official build.

@thomthom thomthom mentioned this issue Feb 27, 2019
Merged
4 tasks
thomthom added a commit to thomthom/yard that referenced this issue Mar 1, 2019
@thomthom
Workaround for broken Browser Back for anchors. Fixes lsegal#1071
e39014e
@lsegal lsegal closed this as completed in 6866751 Mar 31, 2019
lsegal added a commit that referenced this issue Mar 31, 2019
@lsegal
Merge pull request #1228 from thomthom/dev-fix-anchor-history
7579761 
Workaround for broken Browser Back for anchors. Fixes #1071
lsegal added a commit that referenced this issue Apr 2, 2019
@lsegal
Tag release v0.9.19
12f56cf 
References:
  #1071, #1198, #1219, #1226, #1228, #1229, #1231, #1233,
  #1234, #1235
This was referenced Mar 12, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noahgibbs @thomthom