Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting WebP effort to 0 in constructor #3259 #3261

Merged
merged 1 commit into from Jun 17, 2022

Conversation

AlexanderTheGrey
Copy link
Contributor

Setting WebP effort to 0 in the constructor caused the effort to use the
default value of 4.

@lovell
Copy link
Owner

lovell commented Jun 15, 2022

Would something like the following work to ensure we still support the deprecated reductionEffort property?

const effort = is.defined(options.effort) ? options.effort : options.reductionEffort;

Please can you remove the unrelated layout changes too.

@AlexanderTheGrey
Copy link
Contributor Author

Would something like the following work to ensure we still support the deprecated reductionEffort property?

Ah, yes, I modified the code as if it were removed.

Please can you remove the unrelated layout changes too.

Yeah, my VS Code automatically formatted it for some reason.

Setting WebP effort to 0 in the constructor caused effort to use the
default value of 4.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 717b1dc on AlexanderTheGrey:BUG-3259 into b10d8f8 on lovell:main.

@lovell lovell merged commit 4662527 into lovell:main Jun 17, 2022
@lovell
Copy link
Owner

lovell commented Jun 17, 2022

Brilliant, thank you!

@lovell lovell added this to the v0.30.7 milestone Jun 17, 2022
lovell added a commit that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants