Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update word format in resize docs #3410

Merged
merged 1 commit into from Oct 17, 2022
Merged

Update word format in resize docs #3410

merged 1 commit into from Oct 17, 2022

Conversation

ginoemiliozzi
Copy link
Contributor

Just a little update to avoid confusing fit as a valid keyword for the transformation request

@lovell
Copy link
Owner

lovell commented Oct 17, 2022

Thank you for the PR, please can you update the JSDoc in the source then use npm run docs-build to regenerate the documentation.

sharp/lib/resize.js

Line 114 in eacb833

* When using a `fit` of `cover` or `contain`, the default **position** is `centre`. Other options are:

@ginoemiliozzi
Copy link
Contributor Author

@lovell
Sorry I didn't know it has to be done this way, now I did it through the JSDoc as you suggested 👍

@lovell lovell merged commit ae79d26 into lovell:main Oct 17, 2022
@lovell
Copy link
Owner

lovell commented Oct 17, 2022

Thank you!

@ginoemiliozzi ginoemiliozzi deleted the patch-1 branch October 17, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ginoemiliozzi @lovell