Skip to content

Fix compatibility with older python versions #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2021
Merged

Fix compatibility with older python versions #133

merged 1 commit into from
Apr 5, 2021
+8 −3

Conversation

lovasoa
Copy link
Owner

@lovasoa lovasoa commented Apr 5, 2021

#132 broke compatibility with python 3.6

@lovasoa
Fix compatibility with older python versions
8773bda 
#132 broke compatibility with python 3.6
@lovasoa
Copy link
Owner Author

lovasoa commented Apr 5, 2021

Since the majority of users are on python 3.6, this is pretty critical

@lovasoa lovasoa merged commit 4a0cde7 into master Apr 5, 2021
@lovasoa lovasoa deleted the fix-compat branch April 5, 2021 17:41
@anis-campos
Copy link
Contributor

Good to know that it wasn't too bad. 🤔 I was actually wondering why I had to fall back to collections.abc.xxx to check the types.

@anis-campos
Copy link
Contributor

TIL that there is implementation difference in the typing_inspect.get_origin method across the some python versions.

@lovasoa
Copy link
Owner Author

lovasoa commented Apr 5, 2021

See https://docs.python.org/3/library/stdtypes.html#types-genericalias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lovasoa @anis-campos