Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resolution notification with some additional information #1970

Closed
1 task done
mabed-fr opened this issue Aug 4, 2022 · 10 comments
Closed
1 task done

Improve resolution notification with some additional information #1970

mabed-fr opened this issue Aug 4, 2022 · 10 comments
Labels
feature-request Request for new features to be added

Comments

@mabed-fr
Copy link

mabed-fr commented Aug 4, 2022

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Notification, Other

🔖 Feature description

Improve resolution notification with some additional information:

  • DOWN DATE
  • DATE OF UP(ALREADY PRESENT)
  • TOTAL DOWN DURATION

✔️ Solution

Improve resolution notification with some additional information:

  • DOWN DATE
  • DATE OF UP(ALREADY PRESENT)
  • TOTAL DOWN DURATION

❓ Alternatives

NC

📝 Additional Context

NC

@mabed-fr mabed-fr added the feature-request Request for new features to be added label Aug 4, 2022
@mabed-fr mabed-fr mentioned this issue Aug 13, 2022
1 task
@lazyjeffllc
Copy link

Forgive my ignorance, how does this feature request get performed? We just wait for someone to work it or does louislam have to add this feature?

@honestlai

This comment was marked as spam.

@EdyDeveloper

This comment was marked as spam.

@CommanderStorm

This comment was marked as resolved.

@CommanderStorm
Copy link
Collaborator

@mabed-fr
What exactly is your feature request?
Is this a duplicate of Templating (#975) or #2362?
If it is not, please edit your issue to make it more clear ^^

@CommanderStorm
Copy link
Collaborator

@lazyjeffllc

Forgive my ignorance, how does this feature request get performed? We just wait for someone to work it or does louislam have to add this feature?

The Contribution guide is at https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

@mabed-fr
Copy link
Author

Yes these are the same features, but none are started. Unfortunately I don't have the required skills. I can only be useful for the system network and DevOps side

@CommanderStorm
Copy link
Collaborator

Yes these are the same features

Please close this PR then 😉
Duplicates just make managing issues harder

none are started.

My plan to improve upon this state is:

  • reformat the monitors see PR Chore: General notification reformatting #3182
  • make sure that all notification providers code looks similar (see zoho-cliq vs telegram for what I mean)
  • fix that some monitors handle down/up vs general notifications differently
  • after upon improving on the code quality in this area, these features will be easier

I can only be useful for the system network and DevOps side

As mentioned in #1349, this project was lacking in this department. In the past year, it got better a lot, but we are not quite in a place I would call happy.
Louis seems to like manual processes for release management (see #213), but all testing PRs have been accepting ⇒ A PR adding more (unit)tests would likely be accepted and improve future reviews.
Also note #2720

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Aug 31, 2023

Yes these are the same features

@mabed-fr ?

Please also note more specific issues like #2362 which will be resolved in #3394

@CommanderStorm
Copy link
Collaborator

Yes these are the same features

Closing as a duplicate as discussed above

@CommanderStorm CommanderStorm closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

5 participants