Refactor: Extract repeated calls to a shared map #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
changed the title
bdewater
reviewed
Apr 14, 2019
| { | ||
| headers: { 'X-Faraday-Adapter' => adapter }, | ||
| ssl: { | ||
| min_version: '1.0' |
There was a problem hiding this comment.
IMO it's nice that tests can serve as documentation, a value like :TLS1_2 (which is mapped to OpenSSL::SSL::TLS1_2_VERSION) would be a real-life example that can be used here.
There was a problem hiding this comment.
Thanks for chiming in! Alright, let's use a realistic value here, it wont hurt readability, or fool anyone.
iMacTia
approved these changes
Apr 14, 2019
olleolleolle
force-pushed
the
codeclimate-for-nethttppersistent
branch
from
14cb0aa
to
29ed488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows up #972 by extracting some code, to make it pass CodeClimate checks.
Update: It fixed the issue it came to fix.