Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting min/max SSL version for a Net::HTTP::Persistent connection #972

Merged
merged 1 commit into from Apr 14, 2019
Merged

Allow setting min/max SSL version for a Net::HTTP::Persistent connection #972

merged 1 commit into from Apr 14, 2019

Conversation

bdewater
Copy link
Contributor

Basically the same as #792, possible now drbrain/net-http-persistent#94 is merged 馃槃

olleolleolle
olleolleolle approved these changes Apr 14, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extends the adapter to support passing in newly-added options.

@olleolleolle
Copy link
Member

I'll merge this and work on the CodeClimate detail!

@olleolleolle olleolleolle merged commit 8a65a58 into lostisland:master Apr 14, 2019
@olleolleolle olleolleolle mentioned this pull request Apr 14, 2019
Merged
@bdewater bdewater deleted the net-http-persistent-ssl-minmax-version branch April 14, 2019 16:07
@technoweenie technoweenie mentioned this pull request Jun 25, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdewater @olleolleolle