Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memoized w/o block #962

Merged
merged 3 commits into from Mar 31, 2019
Merged

Fix Memoized w/o block #962

merged 3 commits into from Mar 31, 2019

Conversation

technoweenie
Copy link
Member

@technoweenie technoweenie commented Mar 31, 2019

This fixes Faraday::Options.memoized so it stops warning on Ruby 2.7.0. Proc.new without an explicit block is now considered a warning: https://docs.ruby-lang.org/en/trunk/NEWS.html

Fixes #961

Todos

  • squash merge

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method becomes more self-explanatory, now, having this error.

@technoweenie
Copy link
Member Author

technoweenie commented Mar 31, 2019

@olleolleolle To be fair, there isn't any known code that would raise that ArgumentError. That was just the path I went down at first because I forgot to run rbenv local 2.7.0-dev after installing it. I left that check in #memoized though just in case ;)

EDIT:

squash merge

NOOOOOOOO I forgot that part :)

@technoweenie technoweenie merged commit cda3a01 into master Mar 31, 2019
@technoweenie technoweenie deleted the memoized-wo-block branch March 31, 2019 19:51
@technoweenie technoweenie mentioned this pull request Jun 25, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants