Explicitly require date
for DateTime
#844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes an issue where it seems Farday is using
DateTime
, specifically for retry functionality, without requiring it. This leads to aNameError
. Without explicitly requiringdate
, retry functionality fails with the following error:It looks like this was introduced in 6ddf9c3 Perhaps the testing environment, or IRB, automatically requires
date
, but if you just run this in Ruby directly:Ruby version: 2.4.4
Additional Notes
This seems like a straightforward bugfix, but likely doesn't impact many people (no open issues, no Google searches) so I would imagine most Ruby apps have
date
imported somewhere.