Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Faraday::Request serialisable with Marshal. #803

Merged
merged 2 commits into from
May 28, 2018
Merged

Make Faraday::Request serialisable with Marshal. #803

merged 2 commits into from
May 28, 2018

Conversation

michielboekhoff
Copy link
Contributor

@michielboekhoff michielboekhoff commented May 26, 2018

Description

This partially aids #535, or rather the over-arching need for serialisation of Faraday::Request. I didn't include any JSON serialisation in this on purpose, as I believe it needs more discussion.

@iMacTia
Copy link
Member

iMacTia commented May 27, 2018

Thanks @michielboekhoff for taking a shot at this.
No worries for JSON support, we can do one thing at a time 👍
Could you just please rename the existing test_marshal into test_marshal_response for consistency?

@iMacTia iMacTia self-requested a review May 27, 2018 18:14
@michielboekhoff
Copy link
Contributor Author

Thanks for the quick reply, @iMacTia. I've changed the test name to test_marshal_response. Concerning JSON serialisation, could we have a chat about that in #535?

@iMacTia iMacTia merged commit f08a985 into lostisland:master May 28, 2018
@iMacTia
Copy link
Member

iMacTia commented May 28, 2018

@michielboekhoff thanks, merged 👍
And yes we can talk in #535 about JSON serialisation, although I doubt we can do something reversible like YAML and Marshal. I'd also like to understand the use-case for that before reviewing an implementation

@AgentAntelope
Copy link

Thanks very much for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants