Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to RSpec #762

Closed
iMacTia opened this issue Jan 27, 2018 · 8 comments
Closed

Convert tests to RSpec #762

iMacTia opened this issue Jan 27, 2018 · 8 comments
Projects
v1.0
Milestone
v1.0

Comments

@iMacTia
Copy link
Member

iMacTia commented Jan 27, 2018

We currently use MiniTest to test Faraday, but I'm personally not used to it and maintenance is becoming an issue.
Moreover, world seems to have moved to RSpec so I'd like to try rewriting tests with that and reach 100% coverage.
@iMacTia iMacTia created this issue from a note in v1.0 (To Do) Jan 27, 2018
@iMacTia iMacTia added this to the v1.0 milestone Jan 27, 2018
@iMacTia iMacTia moved this from To Do to In progress in v1.0 Jan 31, 2018
@iMacTia iMacTia moved this from In progress to To Do in v1.0 Jan 31, 2018
@iMacTia iMacTia moved this from To Do to In progress in v1.0 Jan 31, 2018
iMacTia added a commit that referenced this issue Feb 10, 2018
@iMacTia
Merge branch '1.0' of https://github.com/lostisland/faraday into feat…
2596fbb 
…ure/#762-rspec
iMacTia added a commit that referenced this issue Mar 8, 2018
@iMacTia
Merge branch '1.0' of https://github.com/lostisland/faraday into feat…
ce7c730 
…ure/#762-rspec
iMacTia added a commit that referenced this issue Jul 21, 2018
@iMacTia
Merge branch '1.0' of https://github.com/lostisland/faraday into feat…
c4f03b7 
…ure/#762-rspec

# Conflicts:
#	lib/faraday.rb
#	lib/faraday/connection.rb
#	test/adapters/logger_test.rb
#	test/parameters_test.rb
@frostmark
Copy link

@iMacTia Hi, this issue is actual at the moment?

@iMacTia
Copy link
Member Author

iMacTia commented Sep 6, 2018

Hi @markfrst, yes I’ve been working on it for a while now, although slowly on my spare time 😅.
You can see the progress on the feature/#762-rspec branch

@frostmark
Copy link

frostmark commented Sep 6, 2018 •
edited

@iMacTia thx, i can help with this 🤓

@iMacTia
Copy link
Member Author

iMacTia commented Sep 6, 2018

That would be very welcome!
Feel free to branch out of the feature/#762-rspec and open a PR against it.
Since we might be working on it at the same time, I'd suggest small PRs focused on few files 👍

@frostmark
Copy link

@iMacTia okay

iMacTia added a commit that referenced this issue Sep 21, 2018
@iMacTia
Merge branch '1.0' of https://github.com/lostisland/faraday into feat…
bac1da1 
…ure/#762-rspec

# Conflicts:
#	lib/faraday.rb
@iMacTia
Copy link
Member Author

iMacTia commented Sep 24, 2018

@markfrst If you're still willing to help, I'd suggest you joining us on gitter so we can avoid working on the same files/features concurrently 😃
Please note I've been working on tests over the weekend and merged latest master changes, so you might need to pull.

@frostmark
Copy link

@iMacTia okay, i joined to gitter. i will try find time for help, maybe i will be have time on the next weekend ⏳

iMacTia added a commit that referenced this issue Oct 29, 2018
@iMacTia
Merge branch '1.0' of https://github.com/lostisland/faraday into feat…
89df1a1 
…ure/#762-rspec

# Conflicts:
#	lib/faraday/utils.rb
iMacTia added a commit that referenced this issue Oct 29, 2018
@iMacTia
Merge branch '1.0' of https://github.com/lostisland/faraday into feat…
340122a 
…ure/#762-rspec

# Conflicts:
#	lib/faraday/utils.rb
@iMacTia iMacTia mentioned this issue Nov 9, 2018
Merged
2 tasks
iMacTia added a commit that referenced this issue Nov 26, 2018
@iMacTia
Merge branch '1.0' of https://github.com/lostisland/faraday into feat…
58a3174 
…ure/#762-rspec

# Conflicts:
#	test/adapters/net_http_persistent_test.rb
iMacTia added a commit that referenced this issue Nov 26, 2018
@iMacTia
Feature/#762 rspec (#832)
f1b2657
@iMacTia
Copy link
Member Author

iMacTia commented Nov 27, 2018

This is now completed as of #832 🎉

@iMacTia iMacTia closed this as completed Nov 27, 2018
v1.0 automation moved this from In progress to Done Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
v1.0
Done
Milestone
v1.0
Development

No branches or pull requests
2 participants
@iMacTia @frostmark