Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACE and CONNECT verbs aren't supported #462

Closed
QuinnWilton opened this issue Jan 27, 2015 · 5 comments
Closed

TRACE and CONNECT verbs aren't supported #462

QuinnWilton opened this issue Jan 27, 2015 · 5 comments
Projects
Milestone

Comments

@QuinnWilton
Copy link

> Faraday.run_request(:trace, 'http://example.com', "", {})
ArgumentError: unknown http method: trace
> Faraday.run_request(:connect, 'http://example.com', "", {})
ArgumentError: unknown http method: connect

Both methods have fairly widespread support among Ruby HTTP clients, and TRACE is supported by Net::HTTP.

@mislav
Copy link
Contributor

mislav commented Jan 27, 2015

We accept PRs to add it to the list of supported methods, including tests that verify that the calls work across adapters

METHODS = Set.new [:get, :post, :put, :delete, :head, :patch, :options]

@iMacTia iMacTia added this to the v1.0 milestone Nov 13, 2017
@iMacTia iMacTia added this to To Do in v1.0 Jan 31, 2018
@technoweenie technoweenie moved this from To Do to In progress in v1.0 Feb 21, 2019
@technoweenie
Copy link
Member

Adding in #861

@iMacTia
Copy link
Member

iMacTia commented Feb 25, 2019

#861 is now merged so this can be closed

@iMacTia iMacTia closed this as completed Feb 25, 2019
v1.0 automation moved this from In progress to Done Feb 25, 2019
@megamorf
Copy link

@technoweenie @iMacTia Is there an ETA when PR #861 will be available in a new release? I'm using InSpec which uses faraday as HTTP library and 0.15.4 was released 27th Nov 2018 and I'm afraid they'll wait until a new version of faraday is available that includes the missing HTTP methods.

inspec> http('https://www.example.org', method: 'TRACE').headers
ArgumentError: unknown http method: trace
from /opt/inspec/embedded/lib/ruby/gems/2.6.0/gems/faraday-0.15.4/lib/faraday/connection.rb:373:in `run_request'

Thanks in advance and kind regards,
Seb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v1.0
Done
Development

No branches or pull requests

6 participants
@technoweenie @mislav @QuinnWilton @megamorf @iMacTia and others