[1.x] Deprecate Authorization helpers in Faraday::Connection

[iMacTia]

Description

After reviewing the authorisation part of middleware, I realised we currently expose helpers in Faraday::Connection to setup the Authorization header. The implementation is quite old (I couldn't find any reference to the Token type, it seems it has been replaced by Bearer), with intra-dependencies that make the code hard to read and maintain.

I believe in v2.0 we should remove the helpers and rework the middleware, but in the meantime this PR will add a deprecation warning to the 1.x branch:

• Deprecate auth helpers in Faraday::Connection
• Update docs to show correct usage of the authorization middleware

[olleolleolle]

Super deprecated!

Nice with the docs changes. Idea: promote the Authorization to first place, the others being not as recommended.

[olleolleolle]

Yay!

[iMacTia]

Idea: promote the Authorization to first place, the others being not as recommended

I like this suggestion, and also the introduction could use some rewording, it's much better now!

[olleolleolle]

This is ready to go, I think! 🥳

[ybiquitous]

Hi, how about marking the deprecated methods by the YARD @deprecated tag?

[ybiquitous]

Oh, sorry. I see the methods were deleted via #1308. 😅

[olleolleolle]

We'll keep the YARD tag in mind for the next time we make a release with a deprecation! Thanks!

[ghost]

I'm getting WARNING: Faraday::Connection#authorization is deprecated; it will be removed in version 2.0. everywhere when using Ruby. Octokit. Is this the reason, and what would need to be done to fix it?

[iMacTia]

@thelucid it most definitely is, it appears something is calling the now deprecated authotization method on the connection. It's really easy to fix it, you just need to follow the updated doc page.

If you point me to the right place in the code where this happen, I might be able to provide further help