Add strict_mode to Test::Stubs #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, users might want to check whether stubbed requests exactly match the parameters and headers. In this case, they expect `Test::Stubs` to raise an error when they add a new parameter in a request. This patch introduces `strict_mode` for the purpose of the expectation. With `strict_mode`, `Test::Stubs` tries to check all a path, parameters, and headers exactly.
* Update UPGRADING.md to highlight adapters being moved out * Cleanup tests * Cleanup Gemfile * Update CI
iMacTia
approved these changes
Aug 1, 2021
|
Oh, thank you! I should have opened a PR into |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #1291
Sometimes, users might want to check whether stubbed requests exactly
match the parameters and headers. In this case, they expect
Test::Stubsto raise an error when they add a new parameter in arequest. This patch introduces
strict_modefor the purpose of theexpectation. With
strict_mode,Test::Stubstries to check all apath, parameters, and headers exactly.
Todos