default proxy to http:// if necessary, fixes #1282 #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
reviewed
May 21, 2021
lib/faraday/options/proxy_options.rb
Outdated
Comment on lines
25
to
27
| if value && !value[:uri].to_s.include?('://') | ||
| value[:uri] = Utils.URI("http://#{value[:uri]}") | ||
| end |
There was a problem hiding this comment.
What do you think of having this check only in the case when String branch?
That looks like the most common use case, and if a URI or Options object is provided then probably the caller knows what they're doing (leaving the door open to override this automatic fix, if necessary)
There was a problem hiding this comment.
Good idea - how about this?
iMacTia
approved these changes
May 22, 2021
|
Thanks @gurgeous, this looks great! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the proxy setting was silently ignored if you accidentally left off the scheme (
something:1234). This change fills in thehttp://if it seems to be missing. Fixes #1282.