Add proxy setting when url_prefix is changed #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this setting, setting the url_prefix after a Faraday::Connection is initialized results in no_proxy settings ignored when using relative paths.
olleolleolle
approved these changes
Apr 27, 2021
iMacTia
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Thanks for raising and fixing this @ci.
This issue also highlights why it's not a good idea to change the url_prefix on an established connection, I'd be curious to know why that's done 🤔
Anyway, this looks good and adds a new test. LGTM 🎉 !
|
@ci feel free to simply increase the limit for |
|
@ci Thank you for taking the time to describe and fix this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this change, setting the url_prefix after a Faraday::Connection is initialized results in no_proxy settings ignored when using relative paths. This would be one of the "proposed" fixes in #1275.
Fixes #1275
Todos