New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Excon adapter with Faraday::Excon gem, and fix autoloading issue with Faraday::NetHttpPersistent #1257
Conversation
Also: fixes autoloading issues with Faraday::NetHttpPersistent
I see you did 2 things, so I added the 2nd thing to the title. Makes the commit message truer. OK, cop.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ This has been a long time coming, and it is happening!
@iMacTia thank you!
Thank you. This speeds up faraday load time by ~20%. |
shouldn't |
@rainerborene totally agree! That's the plan for Faraday v2.0 🎉! |
I was wondering why |
@tisba Ah I think I see what @rainerborene also meant now. The adapters need to be included, as they were included with Faraday before, but This clearly doesn't work, by the time we move out all adapters people will have their dependencies full of clients they might not be using. I'll get this fixed and release a v1.4.1 to address that, thanks both for raising it 👍 ! |
Description
Use Faraday::Excon gem instead of internal adapter.
Also: fixes autoloading issues with Faraday::NetHttpPersistent.