Fix NoMethodError undefined method 'coverage' #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gemfile
Outdated
| @@ -18,7 +18,7 @@ group :lint, :development do | |||
| end | |||
|
|
|||
| group :test, :development do | |||
| gem 'coveralls', require: false | |||
| gem 'coveralls_reborn', '~> 0.21.0', require: false | |||
There was a problem hiding this comment.
I think we can allow any version of coveralls_reborn.
There was a problem hiding this comment.
The fix was only introduced for v "0.21.0" but I removed the explicit version as you recommended.
1 task
This is a fix for lostisland#1254 As mentioned in coveralls-ruby issue: lemurheavy/coveralls-ruby#161, using coveralls-ruby-rebon should fix the problem.
Maroo-b
force-pushed
the
1254_fix_coveralls_issue
branch
from
91fe134
to
85926af
Compare
|
@iMacTia I'm glad that this small fix was helpful. Feel free to share any issue up-for-grabs in this project and I can dedicate some free time to it. |
|
We now get the following So it seems reports are now sent correctly to Coveralls 👍! |
|
@Maroo-b Thanks! I'll send anything that pops in my mind, but for now I'd suggest to look at the "help wanted" and "good first issue" labels in the repo issues 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for #1254
As mentioned in coveralls-ruby issue: lemurheavy/coveralls-ruby#161, using coveralls-ruby-rebon should fix the problem.
Here is a screenshot from the CI logs as a proof :)
