Some docs on EventMachine adapters. #1232
Merged
+99
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
reviewed
Jan 5, 2021
olleolleolle
reviewed
Jan 5, 2021
olleolleolle
approved these changes
Jan 5, 2021
iMacTia
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Nicely done and great improvement to the documentation!
We definitely lack knowledge around the EM area and that affects both adapters code and documentation, unfortunately.
We very much welcome the help, and if your "little time off" would allow then we also welcome new maintainers for the adapter that are being moved to external gems 😄
If interested you can read more on this comment
|
Ta, I'll take a peak. |
|
@damau I'm so sorry I have no idea why this wasn't merged yet and I just noticed it! |
|
Really late reply but no worries!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey. I spent some time digging through the EM adapters so I thought I would document how to use the parallel bits.
Additional Notes
I tried to manage expectations and inform a little on the adapter page. It does behave differently, though obviously for good reason. It's also why I decided not to put parallelization onto the README or front pages.
Also big thanks for all the maintainers. Long time user of Faraday with some time off.